rpc: disallow coinjoin stop if there's no CoinJoin session to stop

dashpay · Jul 11, 2024 · 89ade3e · 89ade3e
1 parent 51b6b94
commit 89ade3e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/doc/release-notes-6107.md b/doc/release-notes-6107.md
@@ -0,0 +1,4 @@
+RPC changes
+-----------
+
+- `coinjoin stop` will now return an error if there is no CoinJoin mixing session to stop
diff --git a/src/rpc/coinjoin.cpp b/src/rpc/coinjoin.cpp
@@ -172,6 +172,9 @@ static RPCHelpMan coinjoin_stop()
     auto cj_clientman = node.coinjoin_loader->walletman().Get(wallet->GetName());
 
     CHECK_NONFATAL(cj_clientman);
+    if (!cj_clientman->IsMixing()) {
+        throw JSONRPCError(RPC_INTERNAL_ERROR, "No mix session to stop");
+    }
     cj_clientman->StopMixing();
 
     return "Mixing was stopped";