perf: pass around a cached block hash during block validation #5613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change saw a ~38% performance improvement in header sync reindex
reproduce via
time ./src/qt/dash-qt --nowallet --testnet --reindex --stopatheight=5
On Develop this took average of 1:48 to finish, on this branch it took 1:07
Issue being fixed or feature implemented
Slow header / block validation
What was done?
Pass around cached block hash
How Has This Been Tested?
Reindexed testnet
Breaking Changes
None
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.