Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): return activation_height in getblockchaininfo for BIP9 softforks #5624

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat(rpc): return activation_height in getblockchaininfo for BIP9 softforks #5624

merged 5 commits into from
Oct 23, 2023

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 19, 2023 •
edited
Loading

Issue being fixed or feature implemented

When expecting a hard fork, we manually calculate activation heights.

What was done?

Returning expected activation height for BIP9 softporks in locked_in status in getblockchaininfo RPC.

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides marked this pull request as draft October 19, 2023 18:17
UdjinM6
UdjinM6 reviewed Oct 20, 2023
View reviewed changes
src/rpc/blockchain.cpp Outdated Show resolved Hide resolved
@ogabrielides ogabrielides changed the title feat(rpc): return activation_height in getblockchaininfo feat(rpc): return activation_height in getblockchaininfo for BIP9 softforks Oct 23, 2023
@ogabrielides ogabrielides added this to the 20 milestone Oct 23, 2023
@ogabrielides ogabrielides marked this pull request as ready for review October 23, 2023 13:52
@ogabrielides ogabrielides added the RPC Some notable changes to RPC params/behaviour/descriptions label Oct 23, 2023
UdjinM6
UdjinM6 approved these changes Oct 23, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta
Copy link
Member

We should have a functional test for this.

PastaPastaPasta
PastaPastaPasta approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 1717d2f into dashpay:develop Oct 23, 2023
7 checks passed
@ogabrielides ogabrielides deleted the activation_height_getblockchaininfo branch October 24, 2023 08:16
@UdjinM6 UdjinM6 mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@thephez thephez Awaiting requested review from thephez

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
3 participants
@ogabrielides @PastaPastaPasta @UdjinM6