Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TODO related fixes for old PRs #5625

Merged
merged 4 commits into from
Oct 23, 2023
Merged

chore: TODO related fixes for old PRs #5625

merged 4 commits into from
Oct 23, 2023

Conversation

knst
Copy link
Collaborator

@knst knst commented Oct 19, 2023

Issue being fixed or feature implemented

V20 release preparation - TODO review

What was done?

fixes previous backports from bitcoin: bitcoin#16917, bitcoin#15404, bitcoin#16127 and follow-up changes for PR #2696

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20 milestone Oct 19, 2023
UdjinM6
UdjinM6 approved these changes Oct 19, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ogabrielides
ogabrielides approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

fanquake and others added 4 commits October 23, 2023 10:46
@fanquake @PastaPastaPasta
fix: missing changes from Merge bitcoin#16917: tests: Move common fun…
4cd5148 
…ction assert_approx() into util.py

96299a9 Test: Move common function assert_approx() into util.py (fridokus)

Pull request description:

  To reduce code duplication, move `assert_approx` into common framework `util.py`.

  `assert_approx()` is used in two functional tests.

ACKs for top commit:
  theStack:
    ACK 96299a9
  practicalswift:
    ACK 96299a9 -- DRY is good and diff looks correct
  fanquake:
    ACK 96299a9 - thanks for contributing 🍻

Tree-SHA512: 8e9d397222c49536c7b3d6d0756cc5af17113e5af8707ac48a500fff1811167fb2e03f3c0445b0b9e80f34935f4d57cfb935c4790f6f5463a32a67df5f736939
@knst @PastaPastaPasta
fix: missing changes from Merge bitcoin#15404: [test] Remove -txindex…
6b5b897 
… to start nodes
@knst @PastaPastaPasta
fix: missing changes from "merge bitcoin#16127: more thread safety an…
b96f3e7 
…notation coverage"
@knst @PastaPastaPasta
fix: removed out-dated todo since "A small overhaul of the way MN lis…
cca9132 
…t/stats UI and data are tied together (dashpay#2696)"
@PastaPastaPasta PastaPastaPasta merged commit d5041b6 into dashpay:develop Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@ogabrielides ogabrielides ogabrielides approved these changes

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
5 participants
@knst @ogabrielides @UdjinM6 @PastaPastaPasta @fanquake