fix: use correct interruption condition in StartCachePopulatorThread
#5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broken since 4788
PastaPastaPasta
approved these changes
Nov 26, 2023
It's just a typo/copy-paste mistake in the preliminary cacheing logic. Not sure how we would test it.. Any suggestions? |
ogabrielides
pushed a commit
to ogabrielides/dash
that referenced
this pull request
Dec 4, 2023
dashpay#5732) ## Issue being fixed or feature implemented dashpay#4788 (comment) noticed while working on dashpay#5731 ## What was done? ## How Has This Been Tested? run a node, check logs - there is a meaningful time span between `start` and `done` now and not just zeros all the time. ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#4788 (comment)
noticed while working on #5731
What was done?
How Has This Been Tested?
run a node, check logs - there is a meaningful time span between
startanddonenow and not just zeros all the time.Breaking Changes
Checklist: