Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve quorum caching (again) #5761

Merged
merged 10 commits into from
Dec 20, 2023
Merged

fix: Improve quorum caching (again) #5761

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b07c5cf
fix: `scanQuorumsCache` should only store cache for blocks in the min…
UdjinM6 Dec 10, 2023
a6e3b05
fix: `scanQuorumsCache` should have enough space to store all quorums
UdjinM6 Dec 10, 2023
f7791d3
fix: the vector we store in `scanQuorumsCache` should be limited by `…
UdjinM6 Dec 11, 2023
6200640
doc: add a note to `quorum list` and `quorum memberof` RPCs that som…
UdjinM6 Dec 11, 2023
4d13a30
refactor: introduce and use `max_store_depth()` helper
UdjinM6 Dec 11, 2023
27bef79
fix: Add cleanup cache to avoid excessive quorum scans
UdjinM6 Dec 13, 2023
d241a65
fix comment in `ScanQuorums`
UdjinM6 Dec 17, 2023
947c626
refactor: add and use `max_cycles()` helper
UdjinM6 Dec 17, 2023
f614d95
fix: apply some suggestions, adjust few things
UdjinM6 Dec 18, 2023
a196812
refactor: use `try_emplace`
UdjinM6 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/llmq/quorums.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ CQuorumManager::CQuorumManager(CBLSWorker& _blsWorker, CChainState& chainstate,
m_peerman(peerman)
{
utils::InitQuorumsCache(mapQuorumsCache, false);
utils::InitQuorumsCache(scanQuorumsCache, false);

quorumThreadInterrupt.reset();
}

Expand Down Expand Up @@ -533,6 +531,18 @@ std::vector<CQuorumCPtr> CQuorumManager::ScanQuorums(Consensus::LLMQType llmqTyp

{
LOCK(cs_scan_quorums);
if (scanQuorumsCache.empty()) {
for (const auto& llmq : Params().GetConsensus().llmqs) {
// NOTE: We store it for each block hash in the DKG mining phase here
// and not for a single quorum hash per quorum like we do for other caches.
// And we only do this for GetMaxCacheCycles() of the most recent quorums
// because signing by old quorums requires the exact quorum hash to be specified
// and quorum scanning isn't needed there.
const int MAX_CYCLES = llmq.useRotation ? llmq.keepOldConnections / llmq.signingActiveQuorumCount : llmq.keepOldConnections;
knst marked this conversation as resolved.
Show resolved Hide resolved
scanQuorumsCache.emplace(std::piecewise_construct, std::forward_as_tuple(llmq.type),
PastaPastaPasta marked this conversation as resolved.
Show resolved Hide resolved
std::forward_as_tuple(MAX_CYCLES * (llmq.dkgMiningWindowEnd - llmq.dkgMiningWindowStart)));
}
}
auto& cache = scanQuorumsCache[llmqType];
bool fCacheExists = cache.get(pindexStore->GetBlockHash(), vecResultQuorums);
if (fCacheExists) {
Expand Down