fix(rpc): pass blockhash into TxToJSON so that getspecialtxes could show correct instantlock/chainlock values
#5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld show correct `instantlock`/`chainlock` values
|
I think that a bug fix like this to match expected behavior; in a rpc that is rarely used is okay to be included in a minor / patch; assuming that we do document it as it is technically a breaking change. But like I said don't think anyone could possibly be relying on this behavior @shumkov please object now or forever hold your peace However @UdjinM6 can we improve tests at all? this probably should've been caught by tests no? |
ogabrielides
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
utACK. (I agree with @PastaPastaPasta this is not really a breaking change)
PastaPastaPasta
approved these changes
Dec 19, 2023
ogabrielides
pushed a commit
to ogabrielides/dash
that referenced
this pull request
Dec 22, 2023
…ld show correct `instantlock`/`chainlock` values (dashpay#5774) ## Issue being fixed or feature implemented `instantlock` and `chainlock` are broken in `getspecialtxes` kudos to @thephez for finding the issue ## What was done? pass the hash and also rename the variable to self-describing ## How Has This Been Tested? run `getspecialtxes` on a node with and without the patch ## Breaking Changes `instantlock` and `chainlock` will show actual values and not just `false` all the time now (not sure if that qualifies for "breaking" though) ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
PastaPastaPasta
pushed a commit
to ogabrielides/dash
that referenced
this pull request
Dec 24, 2023
…ld show correct `instantlock`/`chainlock` values (dashpay#5774) ## Issue being fixed or feature implemented `instantlock` and `chainlock` are broken in `getspecialtxes` kudos to @thephez for finding the issue ## What was done? pass the hash and also rename the variable to self-describing ## How Has This Been Tested? run `getspecialtxes` on a node with and without the patch ## Breaking Changes `instantlock` and `chainlock` will show actual values and not just `false` all the time now (not sure if that qualifies for "breaking" though) ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
instantlockandchainlockare broken ingetspecialtxeskudos to @thephez for finding the issue
What was done?
pass the hash and also rename the variable to self-describing
How Has This Been Tested?
run
getspecialtxeson a node with and without the patchBreaking Changes
instantlockandchainlockwill show actual values and not justfalseall the time now (not sure if that qualifies for "breaking" though)Checklist: