fix: TODO related fixes for post-v21 release #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
approved these changes
Jul 8, 2024
|
build failed here: https://gitlab.com/dashpay/dash/-/jobs/7289203270 |
Restarted - succeed: https://gitlab.com/dashpay/dash/-/jobs/7298034458 |
PastaPastaPasta
added a commit
that referenced
this pull request
Jul 15, 2024
1840c94 fix: drop extra pings - follow up for bitcoin#18638 (UdjinM6) 264e7f9 Merge bitcoin#18638: net: Use mockable time for ping/pong, add tests (MarcoFalke) Pull request description: ## Issue being fixed or feature implemented Split from #6102 ## What was done? So far as bitcoin#19499 is backported, bitcoin#18638 can be finished and removed related workarounds. ## How Has This Been Tested? Run unit/functional tests ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 1840c94 PastaPastaPasta: utACK 1840c94 Tree-SHA512: f34657c14514d6ee596175b3faf9ee44e58e8b0339939a0708d58ab2d119786830c183f9b236ed87c08ef8e1dbd031a38fc596b5aa4d38e10521658df4330e79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Multiple TODO is reviewed and fixes in this PR
What was done?
See commits
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist: