backport: trivial 2024 10 25 pr3

[PastaPastaPasta]

Issue being fixed or feature implemented

Trivial backports

What was done?

How Has This Been Tested?

built locally

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[PastaPastaPasta]

dropped non-trivial commits

[UdjinM6]

utACK 66566f3 but also needs confirmation that Guix is ok (GH had and issue, couldn't reproduce it on my machine though)

[kwvg]

utACK 66566f3

GH Guix is having issues again which is concerning. Most likely because of 27179.

GitLab has reported errors (see TSan build) that are not routine

[UdjinM6]

25677 needs a fix:

diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp
index e1418aa442..f15026cf7b 100644
--- a/src/node/interfaces.cpp
+++ b/src/node/interfaces.cpp
@@ -767,7 +767,7 @@ public:
     bool checkFinalTx(const CTransaction& tx) override
     {
         LOCK(cs_main);
-        return CheckFinalTxAtTip(m_node.chainman->ActiveChain().Tip(), tx);
+        return CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), tx);
     }
     bool isInstantSendLockedTx(const uint256& hash) override
     {

[UdjinM6]

utACK fbc0bce