Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: a bunch of trivial-ish code improvements #6381

Merged
merged 10 commits into from
Nov 12, 2024
Merged

refactor: a bunch of trivial-ish code improvements #6381

merged 10 commits into from
Nov 12, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 3, 2024

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 marked this pull request as draft November 3, 2024 09:50
@UdjinM6 UdjinM6 marked this pull request as ready for review November 3, 2024 11:13
knst
knst previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM efc8c99

src/governance/vote.h Outdated Show resolved Hide resolved
knst
knst approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c32fac0

PastaPastaPasta
PastaPastaPasta approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c32fac0

@PastaPastaPasta PastaPastaPasta merged commit b12f5f5 into dashpay:develop Nov 12, 2024
34 of 35 checks passed
@UdjinM6 UdjinM6 added this to the 22 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst knst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @knst @PastaPastaPasta