Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos in Dash-specific comments #6528

Merged
merged 1 commit into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llmq/params.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct LLMQParams {
// the size of the quorum, e.g. 50 or 400
int size;

// The minimum number of valid members after the DKK. If less members are determined valid, no commitment can be
// The minimum number of valid members after the DKG. If less members are determined valid, no commitment can be
// created. Should be higher then the threshold to allow some room for failing nodes, otherwise quorum might end up
// not being able to ever created a recovered signature if more nodes fail after the DKG
int minSize;
Expand Down
2 changes: 1 addition & 1 deletion src/llmq/quorums.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ CQuorumCPtr CQuorumManager::GetQuorum(Consensus::LLMQType llmqType, const uint25
const CBlockIndex* pQuorumBaseBlockIndex = [&]() {
// Lock contention may still be high here; consider using a shared lock
// We cannot hold cs_quorumBaseBlockIndexCache the whole time as that creates lock-order inversion with cs_main;
// We cannot aquire cs_main if we have cs_quorumBaseBlockIndexCache held
// We cannot acquire cs_main if we have cs_quorumBaseBlockIndexCache held
const CBlockIndex* pindex;
if (!WITH_LOCK(cs_quorumBaseBlockIndexCache, return quorumBaseBlockIndexCache.get(quorumHash, pindex))) {
pindex = WITH_LOCK(cs_main, return m_chainstate.m_blockman.LookupBlockIndex(quorumHash));
Expand Down
2 changes: 1 addition & 1 deletion src/rpc/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ CTxDestination AddAndGetMultisigDestination(const int required, const std::vecto
throw JSONRPCError(RPC_INVALID_PARAMETER, (strprintf("redeemScript exceeds size limit: %d > %d", script_out.size(), MAX_SCRIPT_ELEMENT_SIZE)));
}

// Make the address (simplier implementation in compare to bitcoin)
// Make the address (simpler implementation in compare to bitcoin)
return AddAndGetDestinationForScript(keystore, script_out);
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/util/setup_common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ BasicTestingSetup::BasicTestingSetup(const std::string& chainName, const std::ve
m_node.connman = std::make_unique<CConnman>(0x1337, 0x1337, *m_node.addrman, *m_node.netgroupman); // Deterministic randomness for tests.

// while g_wallet_init_interface is init here at very early stage
// we can't get rid of unique_ptr from wallet/contex.h
// we can't get rid of unique_ptr from wallet/context.h
// TODO: remove unique_ptr from wallet/context.h after bitcoin/bitcoin#22219
g_wallet_init_interface.Construct(m_node);
fCheckBlockIndex = true;
Expand Down
4 changes: 2 additions & 2 deletions src/txmempool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1103,12 +1103,12 @@ void CTxMemPool::removeForBlock(const std::vector<CTransactionRef>& vtx, unsigne
}

/**
* Called when a lenght of chain is increased. Removes from mempool expired asset-unlock transactions
* Called when a length of chain is increased. Removes from mempool expired asset-unlock transactions
*/
void CTxMemPool::removeExpiredAssetUnlock(int nBlockHeight)
{
AssertLockHeld(cs);
// items to removed should be firstly collected to independed list,
// items to removed should be firstly collected to independent list,
// because removing items by `removeRecursive` changes the mapAssetUnlockExpiry
std::vector<CTransactionRef> entries;
for (const auto& item: mapAssetUnlockExpiry) {
Expand Down
2 changes: 1 addition & 1 deletion src/txmempool.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class CChain;
class CChainState;
extern RecursiveMutex cs_main;

// Forward declation for CBLSLazyPublicKey:
// Forward declaration for CBLSLazyPublicKey:
template<typename T> class CBLSLazyWrapper;
class CBLSPublicKey;
using CBLSLazyPublicKey = CBLSLazyWrapper<CBLSPublicKey>;
Expand Down
2 changes: 1 addition & 1 deletion test/functional/rpc_whitelist.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def rpccall(node, user, method):
conn.connect()

# composite commands are presented without space in whitelist
# but space can't be ommitted when using CLI/http rpc
# but space can't be omitted when using CLI/http rpc
# for sack of test, substitute missing space for quorum composite command
params = []
if re.match(r"^quorum[^ ]", method):
Expand Down
2 changes: 1 addition & 1 deletion test/functional/test_framework/blocktools.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def create_block(hashprev=None, coinbase=None, ntime=None, *, version=None, tmpl
block.calc_sha256()
return block

# TODO: imlement MN_RR support here or remove it
# TODO: implement MN_RR support here or remove it
def create_block_with_mnpayments(mninfo, node, vtx=None, mn_payee=None, mn_amount=None):
if vtx is None:
vtx = []
Expand Down
Loading