Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nostd proto not propagated from tenderdash-abci #62

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 9, 2024

Issue being fixed or feature implemented

default-features=false on tenderdash-abci should imply default-features=false on tenderdash-proto, to build it in nostd mode.

What was done?

Fixed features in tenderdash-abci

  • added "std" feature that enables tenderdash-proto/std
  • tenderdash-abci doesn't use default features from tenderdash-proto, to allow fine tuning them

How Has This Been Tested?

GHA

Built manually using a pet project.

Breaking Changes

none

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review April 9, 2024 10:31
@QuantumExplorer QuantumExplorer merged commit 17e57f5 into master Apr 9, 2024
12 checks passed
@lklimek lklimek deleted the fix/nostd-not-building branch April 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants