Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto-compiler): not used no-std proto definitions refer to tonic #63

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 11, 2024

Issue being fixed or feature implemented

After building it multiple times, tenderdash_nostd sometimes refers to tonic which is unavailable due to changed features.
This impacts IDE which shows false errors, etc.

What was done?

  • deprecate "std" feature in favor of "grpc" feature ("std" is using tonic anyway)
  • always build nostd, but don't re-export it in "grpc" mode
  • in proto-compiler, build grpc based on func argument, not based on feature
  • renamed module "tenderdash_std" to "tenderdash_grpc"

How Has This Been Tested?

Run cargo build --no-default-features and cargo build --no-default-features -F grpc multiple times in various combinations to ensure it works

Breaking Changes

  • "std" feature is deprecated but in backwards-compatible way
  • renamed module tendedash_proto::tenderdash_std to tendedash_proto::tenderdash_grpc

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 2e0e177 into master Apr 13, 2024
11 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/nostd-tonic branch April 13, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants