-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps)!: update prost, tokio, tonic and other dependencies #95
Changes from all commits
662d28c
e0e2d66
d60c56f
88c1b5f
a8489d5
ac6a144
222b5ce
3d2d494
1f3ea84
2772180
a971dc9
3efda3d
06c59fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
[workspace] | ||
resolver = "2" | ||
members = ["abci", "proto-compiler", "proto"] | ||
|
||
[workspace.package] | ||
|
||
rust-version = "1.80" | ||
version = "1.1.0" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,7 @@ use std::{ | |
}; | ||
|
||
use bytes::BufMut; | ||
use prost::Message; | ||
use tenderdash_proto::types::CanonicalVote; | ||
use tenderdash_proto::{prost::Message, types::CanonicalVote}; | ||
|
||
use crate::{ | ||
proto::types::{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the Syntax of the The syntax for the #[deprecated(note = "replaced by calculate_sign_hash() to unify naming between core, platform and tenderdash")] This ensures that the compiler properly recognizes the deprecation and provides informative warnings. |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,26 @@ | ||
[package] | ||
version = "1.2.0+1.3.0" | ||
|
||
name = "tenderdash-proto-compiler" | ||
authors = ["Informal Systems <[email protected]>", "Dash Core Group"] | ||
edition = "2021" | ||
description = "Internal tool to download and build tenderdash protobuf definitions; used by proto/build.rs" | ||
publish = false | ||
|
||
rust-version.workspace = true | ||
version.workspace = true | ||
|
||
[lib] | ||
|
||
[dependencies] | ||
walkdir = { version = "2.5.0" } | ||
prost-build = { version = "0.12.4" } | ||
tempfile = { version = "3.10.1" } | ||
regex = { "version" = "1.10.4" } | ||
prost-build = { version = "0.13" } | ||
tempfile = { version = "3.12" } | ||
regex = { "version" = "1.10" } | ||
# Use of native-tls-vendored should build vendored openssl, which is required for Alpine build | ||
ureq = { "version" = "2.9.6" } | ||
zip = { version = "2.1.3", default-features = false, features = ["deflate"] } | ||
ureq = { "version" = "2.10" } | ||
zip = { version = "2.2", default-features = false, features = ["deflate"] } | ||
fs_extra = { version = "1.3.0" } | ||
tonic-build = { version = "0.11.0", optional = true } | ||
tonic-build = { version = "0.12", optional = true } | ||
|
||
|
||
[features] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Inconsistent Imports Detected
The import of
DecodeError
andEncodeError
inproto/src/error.rs
still usesprost::{DecodeError, EncodeError}
. To maintain consistency across the codebase, please update this import totenderdash_proto::prost::{DecodeError, EncodeError}
.🔗 Analysis chain
LGTM! Verify impact on codebase.
The import change from
prost
totenderdash_proto::prost
forDecodeError
andEncodeError
looks good and aligns with the PR objectives. This modification likely reflects updates in the dependency structure or aims to maintain consistency across the project.To ensure this change doesn't introduce any unintended consequences, please run the following script to verify that all usages of
DecodeError
andEncodeError
in the codebase are consistent with this new import:This script will help identify any inconsistencies in the usage or import of these error types across the project.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 825