Implement todos in code #2504
Merged
Implement todos in code #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #2504 +/- ##
==========================================
+ Coverage 52.98% 54.21% +1.23%
==========================================
Files 117 118 +1
Lines 9645 9761 +116
==========================================
+ Hits 5110 5292 +182
+ Misses 4535 4469 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ziv17
force-pushed
the
2503-remove-road-segment-name
branch
from
b7b1561 to
7d04158
Compare
Remove road_segment_name from query if road_segment_id is present. Convert segment_id to integer Skip marker without accurate km when adding road_junction_km
ziv17
force-pushed
the
2503-remove-road-segment-name
branch
from
b8b54e3 to
668d91a
Compare
|
Thanks @ziv17 ! Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove road_segment_name from query if road_segment_id is present.
closes #2503
Remove warning about sqlalchemy filter column operator. Removed by suppressing the warning in the function. The implementation follows the documentation.
closes #2507