-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CARDS-2509: Reference question should support conditions based on sou… #1791
Open
acrowthe
wants to merge
8
commits into
dev
Choose a base branch
from
CARDS-2509
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdumitriu
reviewed
Jul 25, 2024
modules/data-model/forms/api/src/main/java/io/uhndata/cards/forms/api/FormUtils.java
Outdated
Show resolved
Hide resolved
...orms/impl/src/main/java/io/uhndata/cards/forms/internal/ReferenceAnswersChangedListener.java
Outdated
Show resolved
Hide resolved
...orms/impl/src/main/java/io/uhndata/cards/forms/internal/ReferenceAnswersChangedListener.java
Outdated
Show resolved
Hide resolved
...orms/impl/src/main/java/io/uhndata/cards/forms/internal/ReferenceAnswersChangedListener.java
Outdated
Show resolved
Hide resolved
...orms/impl/src/main/java/io/uhndata/cards/forms/internal/ReferenceAnswersChangedListener.java
Outdated
Show resolved
Hide resolved
modules/utils/src/main/java/io/uhndata/cards/utils/ConditionalUtils.java
Outdated
Show resolved
Hide resolved
...tion-status/src/main/java/io/uhndata/cards/formcompletionstatus/ConditionalSectionUtils.java
Outdated
Show resolved
Hide resolved
sashaandjic
added
bug
Something isn't working
and removed
Test me!
Ready for testing
testing...
Testing in progress
labels
Sep 20, 2024
…rce form metadata Add optional condition properties to reference questions: - conditionalProperty: A property on the referenced form to be evaluated - conditionalOperator: The operator that should be used for the comparison. Supports all operators supported by Conditional Sections - conditionalValue: The value that the property should be compared against - conditionalFallback: The value that should be saved instead of the referenced value if the condition is not satisfied - conditionalType: The type of the property that is being compared Refactored backend conditional section code in order to reuse conditional evaluation code Update Reference Test forms to add testing support for new conditional references - Added new section with 4 new questions to the bottom of ReferenceTestCopied. These questions are conditional on ReferenceTestUser being completed - Made one question in ReferenceTestUser mandatory to allow the form to be edited between incomplete and complete
…rce form metadata Add optional error message when a conditional reference is not satisfied - Allows non-text questions to have a text based error display
…rce form metadata - Add invalid source flag to reference questions with no source
…rce form metadata - Updated the import script to support conditional properties of reference questions
…rce form metadata - Clean up unused javadoc - Add missing conditional reference columns to questionnaire import - Add missing null checks
…rce form metadata - Rebase ontop of latest dev to pull in other reference question changes - Code cleanup: - Refactor null checks to remove double negatives - Move condition utils to it's own module - Fix test form naming issues - Clean up constant string naming and reuse utility strings when available
…rce form metadata Improve conditional references to not change source answers if a new valid source is edited while the original source does not meet the condition
acrowthe
added
Test me!
Ready for testing
and removed
bug
Something isn't working
labels
Nov 8, 2024
…rce form metadata Cleanup: Remove ConditionalOperand and move functionality to base Operand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce form metadata
Add optional condition properties to reference questions:
Refactored backend conditional section code in order to reuse conditional evaluation code
Update Reference Test forms to add testing support for new conditional references
To test: