-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CARDS-2571: Reference Questions do not work inside Conditional Sections #1802
Open
acrowthe
wants to merge
2
commits into
CARDS-2509
Choose a base branch
from
CARDS-2571
base: CARDS-2509
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaandjic
added
bug
Something isn't working
and removed
testing...
Testing in progress
labels
Sep 4, 2024
acrowthe
added
Test me!
Ready for testing
and removed
bug
Something isn't working
labels
Sep 11, 2024
sashaandjic
added
testing...
Testing in progress
bug
Something isn't working
and removed
Test me!
Ready for testing
testing...
Testing in progress
labels
Sep 17, 2024
- Update reference question initialization code to check for unlinked reference questions any time a form is edited, not just when a form is created - Search for any reference questions on the form that do not have an answer - Check if the missing questions have an existing answer section. If so, generate an answer - Try to find a source answer for any existing or newly created unanswered reference answers - Prioritize pulling source answers from forms that are already referenced by other reference answers in this form for consistency - Add test case in ReferenceTestCopied form
Fix bug where incorrect form would be prioritized
Could not reproduce the bug after latest rebase and related changes - please let me know if you encounter it again. |
acrowthe
added
Test me!
Ready for testing
and removed
bug
Something isn't working
labels
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
a. Make sure the referenced text answers are from the most recent User form
b. Do not fill out the
Should the conditional section be satisfied
answerShould the conditional section be satisfied
to truePrevious (incorrect) behaviour: