CARDS-2618: Replace Livetable with MaterialReactTable in administration screens #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on screens Add data to the Subject Types table on successfull creation
This comment was marked as resolved.
This comment was marked as resolved.
marta-
reviewed
Jan 8, 2025
modules/data-entry/src/main/frontend/src/dataHomepage/EditButton.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/EditButton.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/EditButton.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/SubjectTypeDialog.jsx
Outdated
Show resolved
Hide resolved
modules/homepage/src/main/frontend/src/adminDashboard/AdminResourceListing.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
+71
to
+90
| <Box sx={{ display: 'flex', flexWrap: 'nowrap', float: 'right'}}> | ||
| <EditButton | ||
| entryType={entryType} | ||
| entryPath={row.original["@path"]} | ||
| admin | ||
| /> | ||
| <ExportButton | ||
| entryPath={row.original["@path"]} | ||
| entryName={row.original.title} | ||
| entityData={row.original} | ||
| entryType={entryType} | ||
| size="medium" | ||
| /> | ||
| <DeleteButton | ||
| entryPath={row.original["@path"]} | ||
| entryName={row.original.title} | ||
| onComplete={dialogSuccess} | ||
| entryType={entryType} | ||
| admin | ||
| /> |
There was a problem hiding this comment.
Is there a way to generate the buttons in the AdminResourceListing component like we used to do with the LiveTable?
There was a problem hiding this comment.
I'd rather not. We have custom onClick, onComplete actions tailored to each component. Also we have just 2 places of makeActions now. For development convenience it is easier to see and change what each button do in the component for now. New Admin pages don't appear that often.
…on screens Addressed codereview comments: better naming for props in use
…on screens Addressed codereview comments: refactoring EditButton code
veronikaslc
force-pushed
the
CARDS-2618
branch
from
64d40ba to
f7efce5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
marta-
reviewed
Jan 9, 2025
modules/data-entry/src/main/frontend/src/dataHomepage/Questionnaires.jsx
Show resolved
Hide resolved
marta-
reviewed
Jan 9, 2025
modules/homepage/src/main/frontend/src/adminDashboard/AdminResourceListing.jsx
Outdated
Show resolved
Hide resolved
…on screens Addressed codereview comments: Custom filtering for Clinics page, exact match of names
…on screens Addressed codereview comments: Better exact mach filtering for all tables except custom filtering
marta-
reviewed
Jan 9, 2025
modules/data-entry/src/main/frontend/src/questionnaire/SubjectTypeDialog.jsx
Outdated
Show resolved
Hide resolved
…on screens Addressed codereview comments: Enabling sorting
marta-
reviewed
Jan 9, 2025
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/dataHomepage/SubjectTypes.jsx
Outdated
Show resolved
Hide resolved
…on screens Addressed codereview comments: Diplay description as formatted text
marta-
reviewed
Jan 9, 2025
modules/statistics/src/main/frontend/src/Statistics/AdminStatistics.jsx
Outdated
Show resolved
Hide resolved
marta-
reviewed
Jan 9, 2025
This comment was marked as resolved.
This comment was marked as resolved.
…on screens Addressed codereview comments: Disable sorting for certain columns
This comment was marked as resolved.
This comment was marked as resolved.
…on screens Addressed codereview comments: Better column names
…on screens Addressed codereview comments: Added pattern column to the Subject types table
…on screens Removed duplicated line Co-authored-by: Marta Girdea <[email protected]>
…on screens Addressed codereview comments: Fixed typo
marta-
reviewed
Jan 9, 2025
modules/data-entry/src/main/frontend/src/dataHomepage/Questionnaires.jsx
Outdated
Show resolved
Hide resolved
…on screens Better styling for table questionnaire description Co-authored-by: Marta Girdea <[email protected]>
…on screens Addressed codereview comments: Correct sorting in stat table
…on screens Removed tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARDS-2618: Replace Livetable with MaterialReactTable in administration screens
Affected Administration components:
Dataflow change:
On the Subject types page the newly created subjet type immediately appears in the table after successful creation