Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Add a warning for subject type pattern input field if any subject of this type already exists #1880

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[misc] Add a warning for subject type pattern input field if any subject of this type already exists #1880

wants to merge 1 commit into from

Conversation

veronikaslc
Copy link
Contributor

Affected components: Subject type edit dialog

@veronikaslc veronikaslc requested a review from marta- January 15, 2025 21:21
sashaandjic
sashaandjic approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@sashaandjic sashaandjic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - all good

If user tries to change the pattern of a type that already exist, the proper message is shown in the dialog.
image

@sashaandjic sashaandjic added tested Passed manual testing, needs code review question Further information is requested labels Jan 17, 2025
@sashaandjic
Copy link
Contributor

sashaandjic commented Jan 17, 2025 •
edited
Loading

QUESTION: Just to double check that this is intended behavior, as it looks OK to me.
I created a patient and a visit. Then I changed the pattern for both.
I created new visit (with pattern), and when I tried to assign it to the existing patient (no pattern) I got this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaandjic sashaandjic sashaandjic approved these changes

@marta- marta- marta- approved these changes

Assignees
No one assigned
Labels
question Further information is requested tested Passed manual testing, needs code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veronikaslc @sashaandjic @marta-