Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix array_agg failed if the argument is NULL #17244

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jan 10, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. fix array_agg(NULL) bug
  2. add some test for array_agg function
root@0.0.0.0:48000/default> select array_agg(null) from numbers(5);
error: APIError: QueryFailed: [4000]invalid data (Collections of zero-sized types are not allowed due to deny-of-service concerns on deserialization.)
  • fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and forsaken628 January 10, 2025 08:49
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 10, 2025
@b41sh b41sh added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@b41sh b41sh enabled auto-merge January 10, 2025 12:05
@b41sh b41sh added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@b41sh b41sh added this pull request to the merge queue Jan 10, 2025
Merged via the queue into databendlabs:main with commit 4470ee5 Jan 10, 2025
70 checks passed
@b41sh b41sh deleted the fix-array-agg branch January 10, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants