Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection option WithSkipTLSHostVerify for privatelink host #225

Merged
merged 1 commit into from
May 28, 2024
Merged

Add connection option WithSkipTLSHostVerify for privatelink host #225

merged 1 commit into from
May 28, 2024

Conversation

jackyhu-db
Copy link
Collaborator

@jackyhu-db jackyhu-db commented May 24, 2024 •
edited
Loading

Background

The driver cannot connect to the workspace whose hostname is an internal private link hostname, this is because its domain is not added into Databricks workspace certificate. See #223

Description

This change adds connection option WithSkipTLSHostVerify which can disable verifying the hostname in the server certificate. In this mode, TLS is susceptible to machine-in-the-middle attacks. Please only use this option when the hostname is an internal private link hostname.

Here is the usage

connector, err := dbsql.NewConnector(
   dbsql.WithServerHostname("<hostname>"),
   dbsql.WithHTTPPath("<http_path>"),
   dbsql.WithAccessToken("<token>"),
   dbsql.WithSkipTLSHostVerify(),
)

@jackyhu-db jackyhu-db force-pushed the PECO-1699 branch 2 times, most recently from 47d1354 to 79ad98f Compare May 28, 2024 16:04
@jackyhu-db jackyhu-db requested a review from benc-db May 28, 2024 16:31
kravets-levko
kravets-levko approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackyhu-db jackyhu-db merged commit 683e392 into databricks:main May 28, 2024
3 checks passed
atzoum pushed a commit to rudderlabs/sqlconnect-go that referenced this pull request Jun 3, 2024
@dependabot
feat(databricks): bump github.com/databricks/databricks-sql-go from 1…
b20a89e 
….5.5 to 1.5.6 (#86)

Bumps
[github.com/databricks/databricks-sql-go](https://github.com/databricks/databricks-sql-go)
from 1.5.5 to 1.5.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/databricks/databricks-sql-go/releases">github.com/databricks/databricks-sql-go's
releases</a>.</em></p>
<blockquote>
<h2>v1.5.6</h2>
<ul>
<li>Added connection option
<code>WithSkipTLSHostVerify</code><code>databricks/databricks-sql-go#225</code><a
href="https://github.com/jackyhu-db"><code>@​jackyhu-db</code></a>)</li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/databricks/databricks-sql-go/compare/v1.5.5...v1.5.6">https://github.com/databricks/databricks-sql-go/compare/v1.5.5...v1.5.6</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/databricks/databricks-sql-go/blob/main/CHANGELOG.md">github.com/databricks/databricks-sql-go's
changelog</a>.</em></p>
<blockquote>
<h2>v1.5.6 (2024-05-28)</h2>
<ul>
<li>Added connection option
<code>WithSkipTLSHostVerify</code><code>databricks/databricks-sql-go#225</code><a
href="https://github.com/jackyhu-db"><code>@​jackyhu-db</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/databricks/databricks-sql-go/commit/9f63de77caf31edbe81a4c42d2243e588b7d4f2d"><code>9f63de7</code></a>
Prepare release v1.5.6 (<a
href="https://redirect.github.com/databricks/databricks-sql-go/issues/226">#226</a>)</li>
<li><a
href="https://github.com/databricks/databricks-sql-go/commit/683e392a58d94db1a0f21dc5efc403e76f5b41d9"><code>683e392</code></a>
Add connection option WithSkipTLSHostVerify for privatelink host (<a
href="https://redirect.github.com/databricks/databricks-sql-go/issues/225">#225</a>)</li>
<li><a
href="https://github.com/databricks/databricks-sql-go/commit/34b734066dbb9b98936f3c226c28de832dc56aa8"><code>34b7340</code></a>
Add connection option WithSkipTLSHostVerify for privatelink host</li>
<li>See full diff in <a
href="https://github.com/databricks/databricks-sql-go/compare/v1.5.5...v1.5.6">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/databricks/databricks-sql-go&package-manager=go_modules&previous-version=1.5.5&new-version=1.5.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benc-db benc-db benc-db approved these changes

@kravets-levko kravets-levko kravets-levko approved these changes

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

@jadewang-db jadewang-db Awaiting requested review from jadewang-db jadewang-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackyhu-db @kravets-levko @benc-db