Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secrets #236

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Remove secrets #236

merged 1 commit into from
Jul 18, 2024

Conversation

yunbodeng-db
Copy link
Contributor

Remove secrets

@yunbodeng-db yunbodeng-db requested a review from jackyhu-db July 18, 2024 15:38
@yunbodeng-db
remove secrets
9d79f73 
Signed-off-by: yunbodeng-db <[email protected]>
kravets-levko
kravets-levko approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope these secrets are inactive/revoked, because they will still remain in git history 🤔

@kravets-levko kravets-levko merged commit a21b124 into databricks:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyhu-db jackyhu-db jackyhu-db approved these changes

@kravets-levko kravets-levko kravets-levko approved these changes

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

@jadewang-db jadewang-db Awaiting requested review from jadewang-db jadewang-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunbodeng-db @kravets-levko @jackyhu-db