Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SSL verification for CloudFetch links #414

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

kravets-levko
Copy link
Contributor

@kravets-levko kravets-levko commented Jul 11, 2024

Fixes #413

Follow up on #405

Even though this is not a proper fix and it should be implemented as an option configured by user, this will allow us to unblock the upcoming release. The proper fix will be implemented as a follow up

Signed-off-by: Levko Kravets <[email protected]>
@kravets-levko
Copy link
Contributor Author

@jackyhu-db (cc @rth) Please check out my second take on this - 0cd439b We already have flag _tls_no_verify that disables SSL cert validation (but still - does not disable SSL itself) for Thrift requests. That flag defaults to False and user should explicitly set it when needed. I decided to extend it for CloudFetch downloader as well. Please let me know what do you think. @rth it would be great if you can actually try this fix. Thanks!

@rth
Copy link

rth commented Jul 16, 2024

Yes, I confirm this works nicely after setting _tls_no_verify=True and closes the linked issue. Thanks a lot @kravets-levko !

@kravets-levko kravets-levko merged commit dbf183b into main Jul 16, 2024
13 checks passed
@kravets-levko kravets-levko deleted the disable-ssl-verification-for-cloudfetch branch July 16, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too large queries produce MaxRetryError
3 participants