Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-event-decoder-vtt #253

Merged
merged 2 commits into from
May 22, 2024
Merged

fix-event-decoder-vtt #253

merged 2 commits into from
May 22, 2024

Conversation

tabmatfournier
Copy link
Contributor

  • two null checks were missed when converting old records that can have null values for valid through timestamps
│       Trace:  java.lang.NullPointerException: Cannot invoke "java.lang.Long.longValue()" because the return value of "io.tabular.iceberg.connect.events.CommitTablePayload.vtts()" is null                        │
│               at io.tabular.iceberg.connect.channel.EventDecoder.convertPayload(EventDecoder.java:119)                                                                                                            │
│               at io.tabular.iceberg.connect.channel.EventDecoder.convertLegacy(EventDecoder.java:82)                                                                                                              │
│               at io.tabular.iceberg.connect.channel.EventDecoder.decode(EventDecoder.java:77)                                                                                                                     │
│               at io.tabular.iceberg.connect.channel.Channel.lambda$consumeAvailable$2(Channel.java:131)                                                                                                           │
│               at java.base/java.lang.Iterable.forEach(Iterable.java:75)                                                                                                                                           │
│               at io.tabular.iceberg.connect.channel.Channel.consumeAvailable(Channel.java:125)        

- two null checks were missed when converting old records that can have null values for valid through timestamps
Copy link
Contributor

@fqtab fqtab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

@tabmatfournier tabmatfournier merged commit e7c07bf into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants