Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I believe most email config vars weren't being set or imported into settings, preventing validation emails from being sent. This allows for the app to grab those variables.
If this is merged I'll add those vars to the staging/production apps.
Notes
I tried setting up a review app for this to make testing easier (hence all those deployments), and got a server error that made it seem like the version of postgres heroku was using wasn't compatible with the version of django that we're using. In trying to fix this I ended up in dependency hell, so for now local testing it is! 🎉
I still have those changes on a different branch in case we did want to set that up in the future.
Testing Instructions
.env.example
(the default .env file the container uses, remember to undo after testing)