Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(npm): [email protected] #672

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jan 8, 2025

Caution

Waiting for release of [email protected]. Update dependency in package.json before merging this PR.

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

image

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added the type: technical debt Describes or removes a technical debt label Jan 8, 2025
@thinkh thinkh self-assigned this Jan 8, 2025
package.json Outdated
@@ -114,7 +114,7 @@
"i18next": "^23.14.0",
"jstat": "^1.9.6",
"jszip": "^3.10.1",
"lineupjs": "4.11.0",
"lineupjs": "git+ssh://[email protected]/lineupjs/lineupjs.git#sgratzl/u6",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to version number once lineupjs is released!

@thinkh
Copy link
Member Author

thinkh commented Jan 14, 2025

The following CSS snippet hides the data mapping icon from the toolbar when linear is selected:

.lu-toolbar > .lu-action-data-mapping:not([data-active]) {
	display: none;
}
lineupjs-auto-hide-data-mapping-from-toolbar.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt Describes or removes a technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant