Skip to content

Commit

Permalink
refactor: not disable color-contrast rule anymore (#3640)
Browse files Browse the repository at this point in the history
  • Loading branch information
mfranzke authored Jan 6, 2025
1 parent c793602 commit 50fb338
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
1 change: 0 additions & 1 deletion packages/components/src/components/select/select.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const testA11y = () => {
const accessibilityScanResults = await new AxeBuilder({ page })
.include('.db-select')
.exclude('test-placeholder')
.disableRules('color-contrast')
.analyze();

expect(accessibilityScanResults.violations).toEqual([]);
Expand Down
10 changes: 3 additions & 7 deletions showcases/e2e/link/link-a11y.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,13 @@ import { test } from '@playwright/test';
import { isStencil, runA11yCheckerTest, runAxeCoreTest } from '../default.ts';
import { lvl3 } from '../fixtures/variants';

const axeDisableRules = isStencil(process.env.showcase)
? ['color-contrast']
: [];

const aCheckerDisableRules = isStencil(process.env.showcase)
? ['text_contrast_sufficient', 'aria_attribute_valid']
: ['aria_attribute_valid']; // TODO: This is a false positive -> add an issue in https://github.com/IBMa/equal-access

test.describe('DBLink', () => {
runAxeCoreTest({ path: '02/link', axeDisableRules });
runAxeCoreTest({ path: '02/link', color: lvl3, axeDisableRules });
runAxeCoreTest({ path: '02/link', density: 'functional', axeDisableRules });
runAxeCoreTest({ path: '02/link' });
runAxeCoreTest({ path: '02/link', color: lvl3 });
runAxeCoreTest({ path: '02/link', density: 'functional' });
runA11yCheckerTest({ path: '02/link', aCheckerDisableRules });
});

0 comments on commit 50fb338

Please sign in to comment.