fix: use MPILock instead of single rank selection.

dbbs-lab · Dec 16, 2024 · eedad94 · eedad94
1 parent 5289acd
commit eedad94
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/bsb/storage/__init__.py b/bsb/storage/__init__.py
@@ -19,6 +19,7 @@
 
 from .. import plugins
 from ..exceptions import UnknownStorageEngineError
+from ..services import MPILock
 from ..services.mpi import MPIService
 
 if typing.TYPE_CHECKING:
@@ -389,7 +390,7 @@ def open_storage(root, comm=None):
     """
     engines = get_engines()
     for name, engine in engines.items():
-        if engine.peek_exists(root) and engine.recognizes(root, MPIService(comm)):
+        if engine.peek_exists(root) and engine.recognizes(root, MPILock.sync(comm)):
             return Storage(name, root, comm, missing_ok=False)
     else:
         for name, engine in engines.items():

diff --git a/bsb/storage/interfaces.py b/bsb/storage/interfaces.py
@@ -116,9 +116,13 @@ def root_slug(self):
 
     @staticmethod
     @abc.abstractmethod
-    def recognizes(root, comm):
+    def recognizes(root, lock):
         """
-        Must return whether the given argument is recognized as a valid storage object.
+        Must return whether the given root argument is recognized as a valid storage object.
+
+        :param root: The unique identifier for the storage
+        :param lock: Window to synchronize read write operations across
+          all MPI processes in the communicator.
         """
         pass