Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated the docs deps, and renamed mpi deps to parallel #769

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Nov 13, 2023

Describe the work done

A couple of different developer dependencies were all clumped together, and the mpi dependency might not be clear enough for people who want to parallelize their code, but are unfamiliar with MPI.

Tasks

  • Updated documentation

@filimarc Please review whether you think this is a positive change, and whether you can think of any places where this has an impact that I may have overlooked :)

@Helveg Helveg requested a review from filimarc November 13, 2023 13:32
@filimarc filimarc self-assigned this Nov 13, 2023
Copy link
Contributor

@filimarc filimarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok

@Helveg Helveg merged commit ff6ecbf into main Nov 13, 2023
9 checks passed
@Helveg Helveg deleted the doc-opt-deps branch November 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants