Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update configuration to store whenever an attribute is set #900

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

filimarc
Copy link
Contributor

@filimarc filimarc commented Nov 27, 2024

Describe the work done

Configuration object method _config_attr_order is updated when an attribute is set using flag_dirty.

List which issues this resolves:

closes #899

Tasks

  • Added tests
  • Code

@github-actions github-actions bot added the fix label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (ab77c6f) to head (3c72b0f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   89.09%   89.12%   +0.03%     
==========================================
  Files         110      110              
  Lines       15164    15208      +44     
==========================================
+ Hits        13510    13554      +44     
  Misses       1654     1654              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests? Can you also see what the impact is with adding and removing elements from a config list? (I think that should be OK though°

Copy link
Contributor

@drodarie drodarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filimarc filimarc requested a review from Helveg December 11, 2024 14:16
@drodarie drodarie merged commit 516dc63 into main Dec 12, 2024
12 checks passed
@drodarie drodarie deleted the fix/stored-cfg branch December 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a stored configuration after modification does not work
3 participants