Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CLI bsb simulate command #909

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix: CLI bsb simulate command #909

merged 3 commits into from
Jan 13, 2025

Conversation

drodarie
Copy link
Contributor

@drodarie drodarie commented Jan 13, 2025 •
edited by github-actions bot
Loading

Describe the work done

  • Fix bsb simulate output folder flag option
  • Update acknowledgments

List which issues this resolves:

closes #908

📚 Documentation preview 📚: https://bsb--909.org.readthedocs.build/en/909/

@drodarie drodarie requested a review from filimarc January 13, 2025 16:36
@drodarie drodarie self-assigned this Jan 13, 2025
@drodarie drodarie changed the title Fix/cli fix: CLI bsb simulate command Jan 13, 2025
@github-actions github-actions bot added the fix label Jan 13, 2025
Helveg
Helveg requested changes Jan 13, 2025
View reviewed changes
docs/cli/commands.rst Show resolved Hide resolved
@drodarie drodarie requested a review from Helveg January 13, 2025 16:51
filimarc
filimarc approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@filimarc filimarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drodarie drodarie merged commit 818de95 into main Jan 13, 2025
10 checks passed
@drodarie drodarie deleted the fix/cli branch January 13, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filimarc filimarc filimarc approved these changes

@Helveg Helveg Helveg approved these changes

Assignees

@drodarie drodarie

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bsb simulate with -o option is broken
3 participants
@drodarie @Helveg @filimarc