Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop microbatch environment variable from tests #1403

Closed
wants to merge 3 commits into from

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Nov 9, 2024

resolves #N/A

Problem

Microbatch functionality is no longer gated behind an environment variable. There is now a behavior flag, however, setting the behavior flag is only necessary if one has a custom microbatch model in their project. Core handles and tests this behavior. We should still run the tests we're running for microbatch in dbt-bigquery, but no longer need to specify the environment variable

Solution

Drop the microbatch environment variable from the tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Nov 9, 2024
@QMalcolm QMalcolm marked this pull request as ready for review November 9, 2024 04:03
@QMalcolm QMalcolm requested a review from a team as a code owner November 9, 2024 04:03
@mikealfare mikealfare closed this Dec 11, 2024
@mikealfare mikealfare deleted the microbatch-behavior-flag-2 branch December 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants