Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snapshots.md content #1948

Closed
1 task
runleonarun opened this issue Sep 7, 2022 · 1 comment
Closed
1 task

Improve snapshots.md content #1948

runleonarun opened this issue Sep 7, 2022 · 1 comment
Assignees
Labels
content Improvements or additions to content good first issue Good for newcomers improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@runleonarun
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/building-a-dbt-project/snapshots

What part(s) of the page would you like to see updated?

  • Move content out of details tabs
  • Can we reconfigure this content to make it easier to read?
  • Add the following context requested from @pofl

I do want to make a small request here. The docs do not mention what type the updated_at field of the timestamp strategy should have. timestamp types work, of course. But what about ISO date strings and unix epoch integers? Please add this (one sentence) to the docs. You can even hijack this PR to add that.

Additional information

Pulling this out of the PR I started a while back.

@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Sep 7, 2022
@runleonarun runleonarun mentioned this issue Sep 7, 2022
7 tasks
mirnawong1 added a commit that referenced this issue Jan 9, 2025
this pr adds what type the updated_at field of the timestamp strategy should have in relation to iso date strings and unix epoch integers.

Resolves # #1948
@mirnawong1 mirnawong1 self-assigned this Jan 9, 2025
@mirnawong1
Copy link
Contributor

closing this as addressed in #6746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content good first issue Good for newcomers improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

No branches or pull requests

2 participants