Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots.md #1304

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Update snapshots.md #1304

merged 5 commits into from
Sep 7, 2022

Conversation

runleonarun
Copy link
Collaborator

Description & motivation

Per @mirnawong1's feedback, the two details blocks are not showing up in the bottom of the page. I think they might just need to include a summary?

To-do before merge

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

Checklist

If you added new pages (delete if not applicable):

  • The page has been added to website/sidebars.js
  • The new page has a unique filename

If you removed existing pages (delete if not applicable):

  • The page has been removed from website/sidebars.js
  • An entry has been added to _redirects

@runleonarun runleonarun requested a review from annafil as a code owner April 4, 2022 20:19
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 0324660
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6317e0a4305f21000a444fa3
😎 Deploy Preview https://deploy-preview-1304--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@runleonarun
Copy link
Collaborator Author

runleonarun commented Apr 4, 2022

When I come back to this:

  • Move content out of details tabs
  • Can we reconfigure this content to make it easier to read?
  • Add context requested from @pofl

I do want to make a small request here. The docs do not mention what type the updated_at field of the timestamp strategy should have. timestamp types work, of course. But what about ISO date strings and unix epoch integers? Please add this (one sentence) to the docs. You can even hijack this PR to add that.

@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label May 17, 2022
@runleonarun runleonarun reopened this May 17, 2022
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: x-small This change will take under 3 hours to fix. labels May 17, 2022
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. content Improvements or additions to content and removed size: x-small This change will take under 3 hours to fix. labels May 27, 2022
@nghi-ly
Copy link
Contributor

nghi-ly commented Sep 6, 2022

@runleonarun : So sorry for the delay in getting this reviewed! As you might have heard, the Docs team will be dedicating time on a regular cadence to manage our PR backlog better. In the spirit of this, I opened this PR to see what I can do to help it along.

Your changes look good and ready for approval but I wasn't sure whether you were going to work on this PR further. Are you ready for me to review this or do you need to make more changes? Thanks!

@runleonarun runleonarun mentioned this pull request Sep 7, 2022
1 task
@runleonarun
Copy link
Collaborator Author

Thanks for the nudge @nghi-ly! I moved the additional thoughts for improvement over to an issue so we can get this merged and fix the error. Can you please review it as is? Thank you! 🙇🏻‍♀️

@nghi-ly nghi-ly merged commit da71431 into current Sep 7, 2022
@nghi-ly nghi-ly deleted the runleonarun-patch-2 branch September 7, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants