Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tableau.md #4461

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Update tableau.md #4461

merged 11 commits into from
Nov 15, 2023

Conversation

rpourzand
Copy link
Contributor

Adding information about Tableau Server - needs review by Diego

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@rpourzand
Update tableau.md
b348f8f 
Adding information about Tableau Server - needs review by Diego
@rpourzand rpourzand requested a review from a team as a code owner November 14, 2023 00:25
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:46am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Nov 14, 2023
@rpourzand
Update tableau.md
27b09c5 
fixing table
@rpourzand
Update tableau.md
c05a7e8 
fixing table again
@rpourzand
Update tableau.md
ea34e27 
one more try on the table fix
rpourzand
rpourzand commented Nov 14, 2023
View reviewed changes
website/docs/docs/use-dbt-semantic-layer/tableau.md
|Windows|`C:\Users\\[Windows User]\Documents\My Tableau Repository\Connectors`|`C:\Program Files\Tableau\Connectors`|
|Mac|`/Users/[user]/Documents/My Tableau Repository/Connectors`|n/a|
|Linux|`/opt/tableau/connectors`| `/opt/tableau/connectors`|

2. Install the [JDBC driver](/docs/dbt-cloud-apis/sl-jdbc) to the folder based on your operating system:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiguofer how does the driver installation instructions change with Server? Btw, I assume that you don't HAVE to publish from Desktop, you can just use the connector directly in Server if you install it properly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it changes... https://help.tableau.com/current/pro/desktop/en-us/examples_otherdatabases_jdbc.htm#specify-the-right-jdbc-driver

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have to do something different when you added it to your Tableau Server instance? I might be confused on the steps required to use our connector in Server

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, steps are same as desktop:

  • Put connector in right place
  • Put driver in right place

If you do this while tableau is "open" (in the case of server, "running"), then you must restart it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I might add that for thoroughness

@rpourzand
Update tableau.md
de708ad 
adding note about initial SQL
@mirnawong1
Copy link
Contributor

mirnawong1 commented Nov 14, 2023 •
edited
Loading

hey @rpourzand and @aiguofer ! i've tweaked the markdown and also turned the 'publish from desktop to server' section into an h3. I've also added bullets to the the 'using integration section so it's easier to read.

this is the staging link - is this PR good to merge?

aiguofer
aiguofer approved these changes Nov 14, 2023
View reviewed changes
Copy link

@aiguofer aiguofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!!

@rpourzand
Copy link
Contributor Author

@mirnawong1 I think this is good to go now!

@mirnawong1 mirnawong1 enabled auto-merge November 15, 2023 09:42
@mirnawong1 mirnawong1 merged commit 1f76ddf into current Nov 15, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-tableau-server-updates branch November 15, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 left review comments

@aiguofer aiguofer aiguofer approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpourzand @mirnawong1 @aiguofer