Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode icon #4478

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Dark mode icon #4478

merged 2 commits into from
Nov 15, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 15, 2023 •
edited
Loading

What are you changing in this pull request and why?

Logo disappeared on the /guides landing page when in dark mode

  • Copied logo to /white dir
  • Updated Public Preview callout

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner November 15, 2023 19:41
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 7:54pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Nov 15, 2023
mirnawong1
mirnawong1 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks great!

@nghi-ly nghi-ly enabled auto-merge November 15, 2023 19:53
@nghi-ly nghi-ly merged commit a96731e into current Nov 15, 2023
6 checks passed
@nghi-ly nghi-ly deleted the ly-docs-dark-mode-icon branch November 15, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nghi-ly @mirnawong1