-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update databricks daggers #6754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
size: small
This change will take 1 to 2 days to address
content
Improvements or additions to content
and removed
size: small
This change will take 1 to 2 days to address
labels
Jan 10, 2025
github-actions
bot
added
the
size: medium
This change will take up to a week to address
label
Jan 10, 2025
mirnawong1
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @joellabes ! good flags and i think we can try to make a custom tooltip so we can communicate disclaimers. this has come up a couple of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
size: medium
This change will take up to a week to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
The databricks table configuration options table used
+
(and++
) to indicate disclaimers, but the plus is meaningful in configs so this is confusing. I've swapped them out for the more idiomatic dagger and double dagger.Before and after:
I would have liked to be able to superscript these (or even better, have nice tooltips that display inline), but I don't think docusaurus supports that.
I also clarified that the reason tblproperties can't be set at table creation is that there isn't a PySpark API for it - the "we do not have" was ambiguous as to whether dbt doesn't support it or it doesn't exist.
Checklist
🚀 Deployment available! Here are the direct links to the updated files: