Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databricks daggers #6754

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Update databricks daggers #6754

merged 6 commits into from
Jan 10, 2025

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Jan 10, 2025

What are you changing in this pull request and why?

The databricks table configuration options table used + (and ++) to indicate disclaimers, but the plus is meaningful in configs so this is confusing. I've swapped them out for the more idiomatic dagger and double dagger.

Before and after:
image

I would have liked to be able to superscript these (or even better, have nice tooltips that display inline), but I don't think docusaurus supports that.

I also clarified that the reason tblproperties can't be set at table creation is that there isn't a PySpark API for it - the "we do not have" was ambiguous as to whether dbt doesn't support it or it doesn't exist.

Checklist


🚀 Deployment available! Here are the direct links to the updated files:

@joellabes joellabes requested review from amychen1776 and a team as code owners January 10, 2025 03:38
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 10, 2025 9:49am

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address content Improvements or additions to content and removed size: small This change will take 1 to 2 days to address labels Jan 10, 2025
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Jan 10, 2025
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joellabes ! good flags and i think we can try to make a custom tooltip so we can communicate disclaimers. this has come up a couple of times.

@mirnawong1 mirnawong1 enabled auto-merge January 10, 2025 09:38
@mirnawong1 mirnawong1 merged commit 4989a23 into current Jan 10, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the update-databricks-daggers branch January 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants