Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that dbt parse doesn't put compiled code in its manifest #6789

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Jan 17, 2025

I was confused about the difference between dbt parse and dbt compile, because since 1.4 they both create a manifest. Turns out that dbt parse doesn't include compiled code, so I added that caveat.

Checklist


🚀 Deployment available! Here are the direct links to the updated files:

@joellabes joellabes requested a review from a team as a code owner January 17, 2025 04:39
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 17, 2025 9:20am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 17, 2025
@joellabes
Copy link
Contributor Author

Arguably, since 1.4 is an unsupported version, we could just remove the commentary about how it doesn't make a manifest in older versoons? Whoever reviews this is welcome to edit that segment out if they agree it's redundant.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joellabes !

@mirnawong1 mirnawong1 enabled auto-merge January 17, 2025 09:16
@mirnawong1 mirnawong1 merged commit 21128eb into current Jan 17, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the joellabes-patch-4 branch January 17, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants