Repository navigation
ci: don't let textlint or prettier block preview builds - #766
Merged
Merged
Conversation
## The Issue On PR ddev#765, `no-todo` errors from textlint stopped both the fork preview build and the `build` job in `test.yml`, so no preview was produced for a draft that only had wording problems. ## How This PR Solves The Issue - `cloudflare-preview-forks-build.yml` no longer runs textlint or prettier. `test.yml` already runs them on fork PRs. - `test.yml` moves textlint and prettier into their own `lint` job, so they still fail the PR but no longer stop `build`. Prettier runs even when textlint fails, so both results show up at once. ## Manual Testing Instructions Open a PR with a `TODO:` in a blog post, both from a branch on ddev/ddev.com and from a fork. The `lint` check should fail, while `build` and `Build site (no secrets)` succeed and the preview deploys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🌐 Fork Preview for PR #766 https://pr-766.ddev-com-fork-previews.pages.dev This preview updates automatically when you push changes to your fork. |
|
PR closed. The Cloudflare Pages preview is no longer updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
On PR #765,
no-todoerrors from textlint stopped both the fork preview build and thebuildjob intest.yml, so no preview was produced for a draft that only had wording problems.How This PR Solves The Issue
cloudflare-preview-forks-build.ymlno longer runs textlint or prettier.test.ymlalready runs them on fork PRs.test.ymlmoves textlint and prettier into their ownlintjob, so they still fail the PR but no longer stopbuild. Prettier runs even when textlint fails, so both results show up at once.Manual Testing Instructions
Open a PR with a
TODO:in a blog post, both from a branch on ddev/ddev.com and from a fork. Thelintcheck should fail, whilebuildandBuild site (no secrets)succeed and the preview deploys.🤖 Generated with Claude Code