Add filter for commonly bundled PHP packages

[ganto]

The PHP packaging between distributions and releases might slightly be different. For an example where this is an issue see #40.

This PR adds php__included_packages which takes a list of PHP packages included in the php-common APT package. It further pre-defines a list of included packages for the most commonly used distribution releases.

This change shouldn't affect any existing roles. However, after merging it might be possible to list the full PHP requirements in a consumer role no matter if it's packaged in the common package or a separate APT package. E.g.

owncloud__required_php_packages:
  # Included in base install:
  # - 'ctype'
  # - 'dom'
  # - 'iconv'
  - 'gd'
  - 'json'

Can then be expressed as:

owncloud__required_php_packages:
  - 'ctype'
  - 'dom'
  - 'iconv'
  - 'gd'
  - 'json'

I'm not at all familiar with the PHP naming, but I somehow feel, that this PR is fuzzing the expression package which now can mean Debian package or PHP module(?). This is a bit unfortunate but clarifying this would mean a much larger change. What do you think?

[ganto]

Seems that PHP packages are also called packages, so the naming is not so wrong after all. 😄

@ypid maybe you also want to have a look at it?

[ganto]

I think I mostly got the packages right for the upstream APT packages, but still need to fix the Ondrej Sury repository packages. At least this seems to be the cause of debops-contrib/ansible-roundcube#24 (comment).

[drybjed]

I've tested this PR on Debian Jessie with and without Sury repositories and on Debian Stretch. It seems to work correctly.

@ganto, let me know when it's ready to merge.

[ganto]

Ok, glad to hear.

Still trying to fix the issue with the Roundcube CI test mentioned above. Although my last commit might probably fix an issue I only encountered mentally, it doesn't make the Roundcube test happy yet. Somewhere is still a bug (or misunderstanding) hidden. Will let you know, once I figured it out.

[drybjed]

@ganto OK.

BTW, since you are working on a role in debops-contrib, did you see my last mailing list post? I'm thinking about merging everything back together: https://lists.debops.org/pipermail/debops-users/2017-August/000078.html

[ganto]

Ok, you can merge now. 👍

I found the issue (forgot to list the 'xml' package).

I'm thinking about merging everything back together: https://lists.debops.org/pipermail/debops-users/2017-August/000078.html

Haven't seen before, but thanks for mentioning. I also had some thoughts that I will reply to your mail.

[drybjed]

@ganto, actually, I'll do it since I'll need to do a new role release, otherwise it won't be available for the Roundcube role.

[ypid]

Nice work guys! Thanks.

I'm thinking about merging everything back together: https://lists.debops.org/pipermail/debops-users/2017-August/000078.html

Seen that. But it was a bit TL;DR for yesterday. Lets see about today :)