Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update rolling batch params to output delta #2636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Dec 12, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@xyang16 xyang16 force-pushed the delta branch 5 times, most recently from a6767bc to dca8119 Compare December 14, 2024 01:55
@xyang16 xyang16 marked this pull request as ready for review December 14, 2024 01:56
@xyang16 xyang16 requested review from zachgk and a team as code owners December 14, 2024 01:56
@xyang16 xyang16 changed the title [python] Update vllm rolling batch to return only deltas [python] Update rolling batch to return only deltas Dec 14, 2024
@xyang16 xyang16 force-pushed the delta branch 4 times, most recently from 9dcdcb5 to b976518 Compare December 14, 2024 02:46
@xyang16 xyang16 changed the title [python] Update rolling batch to return only deltas [python] Update rolling batch params to output delta Dec 14, 2024
@xyang16 xyang16 force-pushed the delta branch 4 times, most recently from 95a2d13 to 91b9f93 Compare December 14, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant