Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selections in docker image build workflow #2643

Merged
merged 13 commits into from
Dec 30, 2024

Conversation

HappyAmazonian
Copy link
Contributor

Description

  • Enable selections in docker image build by using arch as input arg
  • refactor the code to use matrix
  • If this change is a backward incompatible change, why must this change be made? N/A

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

a run with building all images: https://github.com/deepjavalibrary/djl-serving/actions/runs/12423622213
a run with some images: 12423485871

@HappyAmazonian HappyAmazonian requested review from zachgk and a team as code owners December 20, 2024 01:56
@HappyAmazonian HappyAmazonian changed the title Enable selections in docker image build Enable selections in docker image build workflow Dec 20, 2024
.github/workflows/docker-nightly-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-nightly-publish.yml Outdated Show resolved Hide resolved
@@ -30,102 +40,45 @@ env:
jobs:
create-runners:
runs-on: [ self-hosted, scheduler ]
strategy:
matrix:
arch: ${{ fromJson(inputs.arch) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a user passes in a single container, does it need to be specified like ["lmi"], or will "lmi" work as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HappyAmazonian HappyAmazonian merged commit 37606cf into master Dec 30, 2024
16 checks passed
@HappyAmazonian HappyAmazonian deleted the single_image_build branch December 30, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants