Repository navigation
Clarify self-hosted builds and registry dependencies - #35
Merged
WaylandYang merged 5 commits intoOct 18, 2026
Merged
Conversation
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Collaborator
|
Thanks, and good catch: the README is wrong. We'd like a smaller change before merging. Right now the same self-hosting guide is written twice, once in the README (+36 lines) and once in
The note about adjusting the stylesheet's relative import is useful and can stay as is. Once it's slimmed down we're happy to merge. |
…-builds Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README describes both build defaults as the GitHub Pages configuration, although
SOLID_GLASS_BASEdefaults to/and the Pages workflow sets both values explicitly.What changes
Keep the README to the corrected defaults and a link to the installation page. The self-hosting guide lives only in
installation.mdx, with domain-root and subpath examples in one code block, build-time settings, SPA fallback, rebuild requirements, and registry dependency sources. Retain the stylesheet import note so readers use the file's actual installed path.The final diff changes only
README.mdandcontent/docs/installation.mdx. The branch incorporates the currentdevthrough a signed-off merge.How it was checked
npm run docs,npm run typecheck, and production builds using both documented deployment commands pass on Node 26.3.0./and/design/. The README's link resolves to its self-hosting heading, and copying the shared command block preserves the full text. The subpath build was run directly from that copied text./dev/examplesmounts 389 of 389 examples with 0 failed in each theme and no page errors.Before review
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failed