fix: fix for dangerous indexing (#125)

Makefile

@@ -12,7 +12,11 @@ client="mock"
 chosen_tests=""
 responses="pass"
 
-test:
+check-dangerous-indexing:
+	bash tests/check-dangerous-index.sh
+
+
+test: check-dangerous-indexing
 ifeq ($(client), "mock")
 	$(eval n_workers=1)
 else 

src/data_hub/api.py

@@ -1316,7 +1316,7 @@ def row_to_dict(
     for field in fields:
         if "systemType" in field.keys() and field.systemType == "bodyDocument":
             continue
-        if field.value is None:
+        if getattr(field, "value", None) is None:
             value = None
         elif field.type in ["float", "integer", "boolean"]:
             value = field.value

tests/check-dangerous-index.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+
+# Search for the pattern and count the matches
+if [ "$(grep -rE 'if [a-zA-Z_][a-zA-Z0-9_]*\.[a-zA-Z_][a-zA-Z0-9_]* is None:' src | wc -l)" -gt 0 ]; then
+    echo "foo.bar is None pattern found! Replace with \`if getattr(foo, 'bar', None) is None:\`"
+    grep -rE 'if [a-zA-Z_][a-zA-Z0-9_]*\.[a-zA-Z_][a-zA-Z0-9_]* is None:' src
+    exit 1
+else
+    echo "No matches found."
+    exit 0
+fi

tests/test_cli_data.py

@@ -84,6 +84,8 @@ def test_list(config, list_option, json_option):  # noqa: F811
 
 @pytest.mark.parametrize("json_option", JSON_OPTIONS)
 def test_show_db(config, json_option):  # noqa: F811
+    print(config["databases"][0])
+
     stdout = _run_cli_command(
         ["data", "show", config["databases"][0]] + json_option,
         client=config["client"],