Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: annotation improvements #107

Merged
merged 7 commits into from
Nov 4, 2024
Merged

fix: annotation improvements #107

merged 7 commits into from
Nov 4, 2024

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Oct 30, 2024 •
edited
Loading

changes

  • fixed a bug where swapping axes works
  • support for coloring points when we label them
  • removed support for choosing the select column at runtime
  • support for reading in existing labels from the database
  • reading in labels from a database should show colors correctly

@sg-s sg-s self-assigned this Oct 30, 2024
@sg-s sg-s marked this pull request as ready for review October 31, 2024 01:39
@sg-s sg-s requested a review from a team as a code owner October 31, 2024 01:39
sg-s
sg-s commented Oct 31, 2024
View reviewed changes
src/data_hub/axes_callback.js Show resolved Hide resolved
src/data_hub/axes_callback.js Show resolved Hide resolved
src/data_hub/plotting.py Outdated Show resolved Hide resolved
src/data_hub/plotting.py Show resolved Hide resolved
src/data_hub/plotting.py Show resolved Hide resolved
src/data_hub/plotting.py Outdated Show resolved Hide resolved
sg-s
sg-s commented Oct 31, 2024
View reviewed changes
src/data_hub/button_callback.js Show resolved Hide resolved
src/data_hub/hover_callback.js Show resolved Hide resolved
src/data_hub/plotting.py Show resolved Hide resolved
src/data_hub/plotting.py Show resolved Hide resolved
src/data_hub/plotting.py Show resolved Hide resolved
@sg-s sg-s enabled auto-merge (squash) November 1, 2024 14:47
@sg-s sg-s merged commit b20a75f into main Nov 4, 2024
12 checks passed
@sg-s sg-s deleted the interactive-clustering branch November 4, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyjwilli kennyjwilli kennyjwilli approved these changes

Assignees

@sg-s sg-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sg-s @kennyjwilli