Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymization matching strategy #18

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

maks-operlejn-ds
Copy link

No description provided.

@maks-operlejn-ds maks-operlejn-ds changed the title WIP: fuzzy matching strategy Anonymization matching strategy Sep 13, 2023
@maks-operlejn-ds maks-operlejn-ds marked this pull request as ready for review September 13, 2023 14:47
Copy link

@mateusz-wosinski-ds mateusz-wosinski-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about current implementation. Shouldn't this method used rather for anonymize than denanonymize ? I guess we want to catch inaccuracies before anonymization will happen, so that the instance matching will be more precise 🤔

e.g. there may be both John Kennedy and John F. Kenedy in the input and we want to anonymize them to the same value. Am I missing something?

@maks-operlejn-ds
Copy link
Author

I'm not sure about current implementation. Shouldn't this method used rather for anonymize than denanonymize ? I guess we want to catch inaccuracies before anonymization will happen, so that the instance matching will be more precise 🤔

e.g. there may be both John Kennedy and John F. Kenedy in the input and we want to anonymize them to the same value. Am I missing something?

@mateusz-wosinski-ds I would say we should focus on deanonymize, as in general, we want to pass some anonymized string to LLM and then, match entities of the response, that can be slightly different

But maybe we should think about doing it also in anonymization phase - this would require to rebuild anonymizing part from scratch and I guess at some point I will do it, but for now I would leave it like that. But we can discuss during daily 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants