-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymization matching strategy #18
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about current implementation. Shouldn't this method used rather for anonymize
than denanonymize
? I guess we want to catch inaccuracies before anonymization will happen, so that the instance matching will be more precise 🤔
e.g. there may be both John Kennedy
and John F. Kenedy
in the input and we want to anonymize them to the same value. Am I missing something?
libs/experimental/langchain_experimental/data_anonymizer/deanonymizer_matching_strategies.py
Outdated
Show resolved
Hide resolved
libs/experimental/langchain_experimental/data_anonymizer/deanonymizer_matching_strategies.py
Show resolved
Hide resolved
docs/extras/guides/privacy/presidio_data_anonymization/reversible.ipynb
Outdated
Show resolved
Hide resolved
@mateusz-wosinski-ds I would say we should focus on deanonymize, as in general, we want to pass some anonymized string to LLM and then, match entities of the response, that can be slightly different But maybe we should think about doing it also in anonymization phase - this would require to rebuild anonymizing part from scratch and I guess at some point I will do it, but for now I would leave it like that. But we can discuss during daily 😄 |
libs/experimental/langchain_experimental/data_anonymizer/deanonymizer_matching_strategies.py
Show resolved
Hide resolved
This reverts commit 20c29b7.
No description provided.