use current directory as default workspace-folder #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmarti
requested changes
Dec 23, 2022
| @@ -90,7 +90,7 @@ function provisionOptions(y: Argv) { | |||
| 'docker-compose-path': { type: 'string', description: 'Docker Compose CLI path.' }, | |||
| 'container-data-folder': { type: 'string', description: 'Container data folder where user data inside the container will be stored.' }, | |||
| 'container-system-data-folder': { type: 'string', description: 'Container system data folder where system data inside the container will be stored.' }, | |||
| 'workspace-folder': { type: 'string', description: 'Workspace folder path. The devcontainer.json will be looked up relative to this path.' }, | |||
| 'workspace-folder': { type: 'string', default: '.', description: 'Workspace folder path. The devcontainer.json will be looked up relative to this path.' }, | |||
There was a problem hiding this comment.
We should treat it the same with the other commands. Would it make sense to search for the first parent folder with a .devcontainer folder (or a .devcontainer.json file)? Similar to what git does.
There was a problem hiding this comment.
It would make perfect sense, but this is out of my reach in terms of TypeScript knowledge 😅
Feel free to close this PR to let a futur contributor to may be implement this.
There was a problem hiding this comment.
Sounds good, closing for now, thanks!
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably fix #29.