-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for passing --metadata-file from cli arg to buildx build #464 #467
base: main
Are you sure you want to change the base?
Conversation
@Thacai please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
This implements my feature request #464.
It took a bit more than just updating
devContainersSpecCLI.ts
, as the types seemingly had dependencies to each other (I'm no typescript expert, so mostly just copied how the rest of it were made).Result is now we have an optional --metadata-file argument for
devcontainer build
, example:devcontainer build --metadata-file metadata.json --workspace-folder .
This enables outputting a json file as per https://docs.docker.com/engine/reference/commandline/buildx_build/#metadata-file, containing various information about the build process.
This file is used by third party tools, such as jfrog cli, which uses it to explicitly publish build info along side the image.