Conversation
Add oauth2.subjectClaim with base64 (default) and plain formats, and add oauth2.subjectClaimOrder to control plain sub ordering (user-connector or connector-user). Keep compatibility by accepting legacy aliases, and by applying configured order consistently across issuer, authflow id_token_hint matching, logout parsing, introspection, and API refresh operations. Update config examples/docs and extend tests for format/order parsing and behavior. Co-authored-by: AI Assistant Signed-off-by: André Düwel <andre.duewel@mercedes-benz.com>
aduewel
force-pushed
the
plaintext_subjectClaim_support
branch
from
September 9, 2026 07:39
f1ab107 to
1dc587d
Compare
Author
|
Hi @nabokihms may I ask for a review here? Or is an issue mandatory for such an additional feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add configurable formats and field ordering for Dex OAuth2/OIDC
subclaims.What this PR does / why we need it
user-connectorandconnector-userordering.oauth2.subjectClaimandoauth2.subjectClaimOrderoptions and add coverage for configuration, encoding, parsing, and integration paths.The plain format avoids protobuf length-prefix bytes in the claim, allowing AWS
StringLikeconditions to match meaningful subject components.Special notes for your reviewer
go test ./...passes.