Skip to content

refactor(chat): keep one first-party MCP App - #5172

Open
benjaminshafii wants to merge 17 commits into
devfrom
refactor/tool-ui-core-minimal
Open

benjaminshafii wants to merge 17 commits into
devfrom
refactor/tool-ui-core-minimal

Conversation

@benjaminshafii

Copy link
Copy Markdown
Member

Summary

Simplified replacement for #5054. Keep one generated first-party MCP App bundle—connection-action—and expand the shared runtime only when needed.

  • Remove skill/sharing confirmation Apps, plugin_flow formatter, visualization, env-var and created-session widgets, and catalog presentation. Skill CRUD and sharing operations remain available as text and structured results.
  • Keep connection Authenticate/Skip on the standard MCP App host, with retryable failed decisions and no repeated OAuth after a failed question reply.
  • Preserve explicit Open preview / Save for workflow drafts; no automatic navigation. Route artifact connection blockers through the same connection App.
  • Remove unused reconnect retry plumbing and ignored ConnectionCard props.
  • No .devcontainer or .github/workflows changes. No Den package-script build-prefix churn or unrelated queue/attachment/abort changes.

Verification

  • Single connection-action bundle builds; shared package, app, server, and Den typechecks passed during review.
  • Focused suites run separately: frame 173, host connection decisions 40, dashboard tiles 79, generated artifacts 26, agent timeouts 33; all passed.
  • Wider dashboard suite has five matching failures on a clean dev control (80c74d2): four Bun accessor-spy errors and one fixed-date cache fixture. These are not marked passed.
  • Further CI and end-to-end verification pending; no fresh screenshot or end-to-end pass claimed yet.

Design

DESIGN.md P3/P5/P7, S4/S5, C5/C6, T2: progressive disclosure, existing primitives, explicit preview actions, and inline connection recovery. Single-bundle boundary deliberately excludes new confirmation UI.

# Conflicts:
#	ee/apps/den-api/src/mcp/generated-artifact-views.ts
#	ee/apps/den-api/test/mcp-generated-artifact-views.test.ts
…p-core

# Conflicts:
#	apps/server/src/opencode-plugins/openwork-extensions-preview.ts
…p-core

# Conflicts:
#	apps/app/src/components/chat/mcp-app-frame.tsx
… changes

Reduce the generated first-party MCP App surface to one bundle,
connection-action, so the shared runtime can be widened later on solid
ground. The skill-created and plugin-flow confirmation Apps are removed
from Den: create_skill and update_skill are plain tools returning text and
structured details, and library-sharing capabilities return the ordinary
operation response.

Also drop changes outside the tool-UI scope: .devcontainer and CI
workflow edits, the Den test-script build prefixes, the queued-draft
attachment preview refactor, and the abort-row suppression that competes
with dev's TaskRecovery.
@benjaminshafii
benjaminshafii requested a review from a team September 20, 2026 06:27
@mintlify

mintlify Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
differentai 🟢 Ready View Preview Sep 20, 2026, 6:28 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Actions Updated
openwork-app Ignored Ignored Preview Sep 20, 2026 11:07pm UTC
openwork-den Ignored Ignored Preview Sep 20, 2026 11:07pm UTC
openwork-diagnostics Ignored Ignored Preview Sep 20, 2026 11:07pm UTC
openwork-landing Ignored Ignored Preview Sep 20, 2026 11:07pm UTC

@benjaminshafii

benjaminshafii commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Selected evidence: Passed · 3/3 tests · 14/14 assertions · 6 images

Commit 808a57575f54575c4c3852e64174c4bb1c3b0ecc · selected evidence
Required verification is reported separately by the current-head Required verification check.

Open review report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant